[Freeciv-Dev] (PR#1870) FreecivAC: borders patch

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

[ben@xxxxxxxxxxxxxxxxxxxxxx - Thu Jun 26 20:08:45 2003]:

> I've fixed a few bugs with the borders patch, and split it into two. The
> basic newborders-20030626.patch implements "omniscient" borders - i.e.
> clients are given full ownership information for all known map tiles,
> even if they are fogged. If newborders-semifog-20030626.patch is applied
> on top of this patch, then "semi-fogged" borders are used instead, in
which
> ownership is only sent for fogged tiles if they are owned by you, if you
> are just losing ownership of them, or if they are adjacent to tiles that
> you do own. This also saves border information in the savegame. See
> doc/README.borders_patch for more information.

Nice.

If I connect to an old server with the new client, I get a client segfault:

#0  0x807b6d2 in player_color (pplayer=0xbffff594) at tilespec.c:2382
2382
  return COLOR_STD_RACE0 +
(gdb) bt
#0  0x807b6d2 in player_color (pplayer=0xbffff594) at tilespec.c:2382
#1  0x809fbcc in pixmap_put_tile_iso (pm=0x82eed58, x=48, y=23,
canvas_x=224, canvas_y=192, 
    citymode=0, offset_x=0, offset_y=0, offset_y_unit=0, width=64,
height=32, height_unit=48, 
    draw=D_FULL) at mapview.c:1705
#2  0x809d99d in gui_map_put_tile_iso (map_x=48, map_y=23, canvas_x=224,
canvas_y=192, 
    offset_x=0, offset_y=0, offset_y_unit=0, width=64, height=32,
height_unit=48, draw=D_FULL)
    at mapview.c:738
#3  0x806ff30 in put_tile_iso (map_x=48, map_y=23, draw=D_FULL) at
mapview_common.c:660
#4  0x807006c in update_map_canvas (x=48, y=23, width=1, height=1,
write_to_screen=false)
    at mapview_common.c:722
#5  0x806edb2 in refresh_tile_mapcanvas (x=48, y=23, write_to_screen=false)
    at mapview_common.c:47
#6  0x80730bc in handle_unit_info (packet=0x82b4800) at packhand.c:1092
#7  0x8064bf9 in handle_packet_input (packet=0x82b4800, type=5) at
civclient.c:273
#8  0x8067e44 in input_from_server (fd=6) at clinet.c:330
#9  0x8096a5e in get_net_input (data=0x0, fid=6,
condition=GDK_INPUT_READ) at gui_main.c:1136
#10 0x4025d35d in gdk_io_invoke (source=0x82fc7d0, condition=G_IO_IN,
data=0x82fc7b8)
    at gdkevents.c:882
#11 0x4028caca in g_io_unix_dispatch () from /usr/lib/libglib-1.2.so.0
#12 0x4028e186 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#13 0x4028e751 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#14 0x4028e8f1 in g_main_run () from /usr/lib/libglib-1.2.so.0
#15 0x401abe2b in gtk_main () at gtkmain.c:524
#16 0x80965eb in ui_main (argc=1, argv=0xbffffb94) at gui_main.c:958
#17 0x8064b7c in main (argc=1, argv=0xbffffb94) at civclient.c:238
#18 0x403fd9f1 in __libc_start_main (main=0x8064510 <main>, argc=1,
argv=0xbffffb94, 
    init=0x806056c <_init>, fini=0x80d6884 <_fini>, rtld_fini=0x4000ad64
<_dl_fini>, 
    stack_end=0xbffffb8c) at ../sysdeps/generic/libc-start.c:92

jason