[Freeciv-Dev] (PR#4355) Using goto for helicopter crashes client

["Cameron Morland" <cameron@xxxxxxxxxx>]

As soon as I hit 'g' when using a helicopter, the client crashes with
the backtrace which follows. The attached patch fixes it.

0: unknown move_type
civclient: shared.c:662: die: Assertion `0' failed.

Program received signal SIGABRT, Aborted.
0x402bea51 in kill () from /lib/libc.so.6
(gdb) bt  
#0  0x402bea51 in kill () from /lib/libc.so.6
#1  0x402be872 in raise () from /lib/libc.so.6
#2  0x402bf986 in abort () from /lib/libc.so.6
#3  0x402b8ae9 in __assert_fail () from /lib/libc.so.6
#4  0x080c8301 in die (format=0x80f49c1 "unknown move_type") at shared.c:662
#5  0x080ad2dc in pft_fill_unit_parameter (parameter=0x81015d0, 
    punit=0x832a560) at pf_tools.c:283
#6  0x0806c059 in enter_goto_state (punit=0x832a560) at goto.c:343
#7  0x0806a0a9 in request_unit_goto () at control.c:577
#8  0x400981ab in gtk_item_factory_new () from /usr/lib/libgtk-1.2.so.0
#9  0x400a81b9 in gtk_marshal_NONE__NONE () from /usr/lib/libgtk-1.2.so.0
#10 0x400d7b6c in gtk_signal_remove_emission_hook ()
   from /usr/lib/libgtk-1.2.so.0
#11 0x400d6fd5 in gtk_signal_set_funcs () from /usr/lib/libgtk-1.2.so.0
#12 0x400d50b3 in gtk_signal_emit () from /usr/lib/libgtk-1.2.so.0
#13 0x4003b3f8 in gtk_accel_group_activate () from /usr/lib/libgtk-1.2.so.0
#14 0x4003b4bf in gtk_accel_groups_activate () from /usr/lib/libgtk-1.2.so.0
#15 0x4011396a in gtk_window_set_default_size () from
/usr/lib/libgtk-1.2.so.0
#16 0x400a7e43 in gtk_marshal_BOOL__POINTER () from /usr/lib/libgtk-1.2.so.0
#17 0x400d7013 in gtk_signal_set_funcs () from /usr/lib/libgtk-1.2.so.0
#18 0x400d50b3 in gtk_signal_emit () from /usr/lib/libgtk-1.2.so.0
#19 0x4010bb0b in gtk_widget_event () from /usr/lib/libgtk-1.2.so.0
#20 0x400a7d15 in gtk_propagate_event () from /usr/lib/libgtk-1.2.so.0
#21 0x400a6efe in gtk_main_do_event () from /usr/lib/libgtk-1.2.so.0
#22 0x401564d7 in gdk_wm_protocols_filter () from /usr/lib/libgdk-1.2.so.0
#23 0x401850b1 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#24 0x40185568 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#25 0x40185798 in g_main_run () from /usr/lib/libglib-1.2.so.0
#26 0x400a67f7 in gtk_main () from /usr/lib/libgtk-1.2.so.0
#27 0x08095536 in ui_main (argc=1, argv=0xbffffc54) at gui_main.c:952
#28 0x080659c6 in main (argc=1, argv=0xbffffc54) at civclient.c:238

helicrash.diff
Description: helicrash.diff