[Freeciv-Dev] Re: (PR#4260) get_defender bug

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 19 May 2003, Mike Kaufman wrote:

> On Mon, May 19, 2003 at 04:59:58AM -0700, Gregory Berkolaiko wrote:
> > 
> > On Sun, 18 May 2003, Per I. Mathisen wrote:
> > 
> > > On Sun, 18 May 2003, Mike Kaufman wrote:
> > > > 1: get_defender bug: Gro Harlem Brundtland's Archers vs Tassilo III's
> > > > Archers (total 4 units) on Ocean at (9,36).
> > > > > civserver: combat.c:514: get_defender: Assertion `0' failed.
> > > > Aborted (core dumped)
> > > >
> > > > #00x400e3021 in __kill () at __kill:-1
> > > > #10x400e2ca8 in raise (sig=1075741620) at ../sysdeps/posix/raise.c:27
> > > > #20x400e456c in *__GI_abort () at ../sysdeps/generic/abort.c:88
> > > > #30x400dc01a in *__GI___assert_fail (assertion=0x0, file=0x0, line=0,
> > > >   function=0x80f0489 "get_defender") at assert.c:83
> > > > #40x080a197b in get_defender (attacker=0x8687738, x=9, y=36) at
> > > > combat.c:514
> > > > #50x080d003f in find_something_to_kill (pplayer=0x817e088,
> > > > punit=0x8687738,
> > > >   x=0xbffffb54, y=0xbffffb58) at aiunit.c:2229
> > > 
> > 
> > I believe it's normally caused by units in a transport belonging to 
> > another player.  Mike, is it the case here?
> 
> Only possibly, but it's bug if so, we don't have any allies, this is a 
> straight AI autogame. What's interesting is that there is only one of 
> Gro Harlem Brundtland' archers are anywhere close to (9,36) and he's pretty 
> far away (I don't think even a great convoy of transporting triremes can 
> get him to 9,36). And this assert happens that same turn. I would guess 
> that the owner got changed somehow, yet taking over Gro and sitting there
> will avoid the core...

Gro's archers don't have to be anywhere near, the iteration runs over 
_all_ enemy units.  The big question is what is on tile (9,36).

It seems there are land units on a ocean tile without the transport.  This 
really should be investigated.  I seem to remeber there were some changes 
to the transporter code done recently.  

> I've uploaded the game in question:
> 
> Gro_and_Tass_get_defender.sav.gz to incoming/

I don't think I can use it, unfortunately...  Even my computer at home is 
switched off, so I cannot debug over ssh.

G.