[Freeciv-Dev] Re: (PR#4107) Client crash on start.

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Believe it or not, the cause of this bug is the resent change to AI 
government evaluation.  This is the backtrace of the offending command on 
the server-side:

#0  send_unit_info (dest=0x813608c, punit=0x82e52e8) at unittools.c:2005
#1  0x080970a2 in city_support (pcity=0x833e668) at city.c:2070
#2  0x08097113 in generic_city_refresh (pcity=0x833e668,
    refresh_trade_route_cities=true) at city.c:2091
#3  0x080bc9ee in ai_best_government (pplayer=0x813608c) at aihand.c:360
#4  0x080bb955 in ai_data_turn_init (pplayer=0x813608c) at aidata.c:256
#5  0x080bba10 in ai_data_get (pplayer=0x813608c) at aidata.c:282
#6  0x080bdac5 in is_player_dangerous (pplayer=0x813608c, aplayer=0x813608c)
    at aitools.c:82
#7  0x080b6432 in assess_danger (pcity=0x833de00) at advmilitary.c:441
#8  0x080b6244 in assess_danger_player (pplayer=0x813608c) at advmilitary.c:354
#9  0x0804f98f in srv_loop () at srv_main.c:1762
#10 0x0804f4b9 in srv_main () at srv_main.c:1574
#11 0x0804a224 in main (argc=3, argv=0xbffff904) at civserver.c:154


I think the best solution is to remove (or at least move) the 
assess_danger_player from srv_loop.  The comment says it will confusethe 
AI, but I don't see why, as it will not _do_ anything, just do some 
advisory stuff.

G.