[Freeciv-Dev] (PR#3648) Superfluous tiles bug

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

[ali - Fri Mar  7 13:03:09 2003]:

> I think this patch here will significantly reduce lag when a player
> reconnects. It should probably be applied to the pubservers.
> 
> I set up a client to study incoming packets in the hope of optimizing
> the network code itself, failed miserably, but found some redundancy
> that seems not to increase the systems robustness.
> 
> When a dead player reconnects, the number of PACKET_TILE_INFOs is
> reduced by 50% because each tile was blessed with to identical packets.
> When a living player reconnects, the gain seems to be ~43%.
> 
> The other patch deals with Apollo. Seems the whole damn map is sent
> every turn, and in duplicate because of the first bug! In function
> do_apollo_program() it seems superfluous to send tile and city info,
> since it's taken care of elsewhere in the code after map_know_all()
> is called. You still get updates when a fogged city changes.
> 
> I tested by having the client check if a packet actually contained
> new information. In the case of Apollo, 4000 out of 4006 packets each
> turn were wasted (default mapsize 80 x 50 = 4000).

Most of this change is obsoleted by PR#3948.  I'm not sure about the
rest, but I'm not convinced in any case that it is correct in all cases.
 It probably deserves another look though.

jason