[Freeciv-Dev] Re: (PR#3757) support for muti citizens icons in server side.

["Rafa³ Bursig" <bursig@xxxxxxxxx>]

Dnia 2003.03.29 19:23, Jason Short napisa³(a):
> 
> [bursig - Mon Mar 24 14:41:17 2003]:
> 
> > Here is pure version of this code that add only server/net protocol
> > support for multi citizens icons system.
> 
> I really don't like the special-casing of the "generic" tag to load
> the original citizen graphics.  IMO this can be done more elegantly by
> using the graphic tag more intuitively.
> 
> graphic tag = "citizens"
>  => sprite tag = "citizens.entertainer"
> graphic tag = "ancient"
>  => sprite tag = "ancient.entertainer"
> 
> 
Hmm... This is the same "hack" that "generic", only made in rulesets 
side.
But why one group of citizens you want call "citizens" and others 
"ansient", "industrial", etc.
There are all citizens icons. I use "generic" becouse some tilesets 
themes can use other "alt" tags that "generic".

I agree that this reduce load code but give name problems, in this way 
old (generic) citizens icons should be rename to "default" and load :

graphic tag = "ancient"
  => sprite tag = "ancient.entertainer"
graphic alt tag = "default"
   => sprite alt tag = "default.entertainer"

but this cut compatibility with old tilesets files.

But this isn't problem server/net support of this code that I want 
commit to cvs only future implementation of client side load code ( 
which isn't supported by this patch )

When we deside on name terminology we only need change names in 
rulesets files and change client load code, not this server/protocol 
code.

> There are two impending problems, that don't have to be resolved by
> this patch (but will come up when we start to use this functionality).
> 
> First, most clients use the citizen graphics before the ruleset data
> is sent.  I think the easiest/best way to allow this is to have a tag 
> for
> a "generic" citizen, i.e. sprite tag = "citizen_generic" or some such.
> This will also work when/if all citizen types are ruleset-specified
> (which would make it hard to show entertainers and scientists at all,
> much less before connecting to the server).
> 
> The other problem is that these theme graphics are used in two
> different ways: in the mapctrl panel (by some GUIs) and in the city 
> dialog.
> There is no real reason why these two need to have the same graphics 
> - they
> have different size constraints.
> 
As I say this patch is first part of this code that don't touch those 
problems. It's only give clients info about exist of citizens styles 
and don't touch others GUIs and they functionality.

But current I need this protocol support becouse my home tree is litle 
overloaded and I want make some cvs commits.

Rafal

----------------------------------------------------------------------
KLIKNIJ 2 razy TAK >>> http://link.interia.pl/f170d