[Freeciv-Dev] Re: (PR#3648) Superfluous tiles bug

["a-l@xxxxxxx" <a-l@xxxxxxx>]

On Mon, 7 Apr 2003 01:18:48 -0700
"Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:

> > --- cvs/server/maphand.c    Sat Feb 22 10:43:01 2003
> > +++ antilag1/server/maphand.c       Fri Mar  7 12:23:09 2003
> > @@ -324,7 +324,9 @@
> >     send_tile_info_always(pplayer, &pconn->self, x, y);
> >        } else if (map_get_known(x, y, pplayer)) {
> >     send_NODRAW_tiles(pplayer, &pconn->self, x, y, 0);
> > -   send_tile_info_always(pplayer, &pconn->self, x, y);
> > +    if (!map_get_sent(x, y, pplayer)) {
> > +      send_tile_info_always(pplayer, &pconn->self, x, y);
> > +    }
> >        }
> >      } conn_list_iterate_end;
> >    } whole_map_iterate_end;
> 
> I'm pretty sure this is not safe.  (...)


> > > [...]  I still think a fix should be applied to the
> > > pubservers.  [...]
> > 
> > This was done yesterday (Sunday).  The patch applied cleanly to all
> > versions but I haven't playtested anything.  Let us know if anything
> > breaks.
> 
> I take it nothing has broken?  Should this go in to CVS?

I think it works. When I encounter bugs playing on pubserver, I
attribute them to my heavily modified client. I have only looked at a
dozen functions in the server code, related to this. What I can say,
is that from the client's perspective, this patch stops the flow of
small tile info packets that contain no information the client did
not already have.


Arnstein