[Freeciv-Dev] Re: (PR#3489) Patch to add new generator

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Josh,

The generator you implemented is a bit specialised and artificial.  I am 
not sure how many people will ever use such generator.  To me, it looks 
more like a "automated scenario constructor" and I feel it is not generic 
enough to be shipped with the main distribution.

Right now there are attempts to rewrite and clean up the map generation.  
It is planned to have a possibility of "external" or "pluggable" map 
generators, although I am not sure if there are any ideas concerning the 
implementation.  I feel that your generator falls into this cathegory of 
external generators.

You are most welcome to join the work on the mapgen as a whole, I can
direct you to various threads that discuss what should be done.  You are
also welcome to propose designs for the external generator / Freeciv
interface.  We do need your help!

Best wishes,
G.


On Mon, 31 Mar 2003, jjc@xxxxxxxxxxxxxxxxxx wrote:

> On Sat, Mar 29, 2003 at 12:25:07PM -0800, Mike Kaufman wrote:
> > On Thu, Mar 27, 2003 at 03:32:37PM -0800, jjc@xxxxxxxxxxxxxxxxxx wrote:
> > > I humbly submit what I hope is the last version of my patch to add a new 
> > > generator 6. This patch fixes some problems with generating too many 
> > > mountains
> > > in the player's peninsula.  It also removes one of  the isthmus loop 
> > > so it is a little shorter.  
> > > 
> > > It is generated in relation to cvs.  I think it is ready for committing 
> > > into 
> > > cvs.  
> > 
> > josh-
> > 
> > could you please put up a couple of screenshots somewhere (or if you can't
> > upload them to the ftp server) and send us a savegame with a map using this
> Savegames and screenshots are up at:
> http://www.honors.montana.edu/~jjc/gen_6_upload/
> 
> > generator? Also please review doc/CodingStyle. your code isn't compliant.
> New patch.
> Changes:
> Now the isthmus road defaults to the center, instead of left side.
> Added enum to eliminate use of T_GRASSLAND to mean new land created.
> Ran indent -kr -i2 -l77 on the file to get it to conform to the 
> coding style.
> Added header comments to all new functions that I introduced.