Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2003:
[Freeciv-Dev] (PR#3649) Network usage optimization
Home

[Freeciv-Dev] (PR#3649) Network usage optimization

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: arnstein.lindgard@xxxxxxx
Subject: [Freeciv-Dev] (PR#3649) Network usage optimization
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 25 Mar 2003 21:43:02 -0800
Reply-to: rt@xxxxxxxxxxxxxx

[ali - Fri Mar  7 18:22:01 2003]:

> I wrote:
> > The attached patch reduces the total bandwidth consumption of a
> > typical Freeciv game with about 25%, just by editing 6 lines
> > of serializing code.
> 
> Ouch, I forgot to add a new mandatory capstring
> after modifying common/packets.c.

My mistake; I didn't look at the capstring part closely at all.  Not
only is the name inappropriate, but there's no capability description.

This patch renames the capability (this is the equivalent of introducing
a new manditory capability) and adds a comment.  Alternately, we could
do without the rename (although the current name is quite bad - again my
mistake).

jason

Index: common/capstr.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/common/capstr.c,v
retrieving revision 1.127
diff -u -r1.127 capstr.c
--- common/capstr.c     2003/03/23 19:19:03     1.127
+++ common/capstr.c     2003/03/26 05:40:07
@@ -76,7 +76,7 @@
 
 #define CAPABILITY "+1.14.0 conn_info +occupied team tech_impr_gfx " \
                    "city_struct_minor_cleanup obsolete_last class_legend " \
-                   "+impr_req +waste +fastfocus +continent +netopt1"
+                   "+impr_req +waste +fastfocus +continent +small_dipl"
   
 /* "+1.14.0" is protocol for 1.14.0 release.
  *
@@ -109,6 +109,9 @@
  * "fastfocus" removes the server from client unit focus.
  *
  * +continent": the server gives the client continent information
+ *
+ * "small_dipl" makes the player diplomacy data in the player packet
+ * smaller, by sending 8-bit instead of 32-bit values.
  */
 
 void init_our_capability(void)

[Prev in Thread] Current Thread [Next in Thread]