[Freeciv-Dev] Re: [PATCH] Add generator which simulates plate tectonics

[Josh Cogliati <jjc@xxxxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Mar 22, 2003 at 11:38:02PM -0800, sam+civ@xxxxxxxxxxxxxxxxxxxx wrote:
> [Sorry about the last posting]
> This patch is designed to be applied after applying Josh Cogliati's patch
> (http://rt.freeciv.org/Ticket/Display.html?id=3489) which adds a sixth 
> map generator to freeciv.
> 
> To use this patch, simply set the generator to 7 (which will generate
> pure tectonic shift maps) or 8 (which will generate hybrid maps: Maps
> which are tectonically generated maps with filtered noise added so that
> the oceans have more islands to explore).
> 
> Note that this code takes far longer to generate maps than the other
> generators; on the other hand, the lands generated are far more realistic,
> especially for larger maps.
Four comments from a short look at the patch:
1.  The maps that it generates are nice looking.  I am not sure how
playable they will be, but they are much more interesting than any existing
maps.  They do seem much closer to 'earthlike' maps than any existing 
map generators.
2.  It is slow to generate maps.  On my 233Mz K6, it took on the order 
of 5 minutes to generate a 200x100 map.  The time seemed to vary by at
least a factor of 2 even with identical settings.
3.  The patch does not apply cleanly to the current cvs after Patch#3489 is
applyed.  This is the reject that I got (I am not sure how to manually fix):
***************
*** 1209,1215 ****
    /*!PS: I don't have the time to have several test runs */
    /* to find a mapping from percents to generator 1 settings. */
  
-   if(map.generator==1){
      /*map.riverlength*= 10; */
      /*I leave this out, people will get too upset 
        if they have to change all their scripts */
--- 1213,1219 ----
    /*!PS: I don't have the time to have several test runs */
    /* to find a mapping from percents to generator 1 settings. */
  
+   if(map.generator==1 || map.generator==7){
      /*map.riverlength*= 10; */
      /*I leave this out, people will get too upset 
        if they have to change all their scripts */
4.  It does not update the server variable documentation in stdinhand.c
with new documentation.  (See how Patch #3489 handles this).

-- 
Josh Cogliati