[Freeciv-Dev] Re: (PR#2521) general effects framework

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Mar 12, 2003 at 08:53:08PM -0800, rwetmore@xxxxxxxxxxxx wrote:
> You are still getting a fair amount of noise from the widening to int.
> 
> Your bools appear to really be 32 bit ints in a number of cases which
> means sign extending and/or clearing high bits are where you spend
> most of your instructions on assignments or are forced to choose less
> efficient instructions or sequences.
> 
> I still suspect you are not looking at the common case usage pattern
> which should be in boolean expressions, and are instead picking the
> worst case scenario.
> 
> But without bool_t == uchar_t and some careful coding practice to
> make optimal use of bit accesses, there will still be some noise.
> This is the tradeoff vs memory usage.
> 
> The rule should be don't do this unless you need the tradeoff, though.

And this is my point. Mike should do some benchmarking. Without this I
think the canonical form should be used. The canonical form here is to
use "bool".

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Understanding is a three-edged sword; 
  your side, their side, and the truth."
    -- a well-known Vorlon