[Freeciv-Dev] Re: (PR#3427) Remove noreturn attribute

["Reinier Post" <rp@xxxxxxxxxx>]

On Fri, Feb 28, 2003 at 02:14:37AM -0800, Raimar Falke wrote:
> On Fri, Feb 28, 2003 at 01:13:39AM -0800, Jason Short wrote:
> > Raimar Falke wrote:
> > > On Thu, Feb 27, 2003 at 09:19:18AM -0800, Reinier Post wrote:
> > 
> > > Next version without variadic arguments. Tested with gcc and icc6.
> > 
> > > +#define die(format, args...)    \
> > > +  do{                           \
> > > +    real_die(format , ## args); \
> > > +    exit(EXIT_FAILURE);         \
> > > +  } while(0)
> > > +
> > 
> > Um, those are variadic arguments.
> 
> *reading* Yes. __VA_ARGS__ is the version from C99. "## args" is the
> gcc extension.
> 
> So since we don't want/can require a C99 compiler I will propose again
> my first fix.
> 
>       Raimar

I do not understand.  Neither are C89 compliant.
We have variadic arguments of functions in the code already.
Keep Freeciv C89 compliant as long as you don't have an actual reason
to break it.  BTW I think it's ridiculous to use macros for cases
like this.

-- 
Reinier