[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

["rwetmore@xxxxxxxxxxxx" <rwetmore@xxxxxxxxxxxx>]

Raimar Falke wrote:
> On Wed, Feb 26, 2003 at 08:55:12PM -0800, rwetmore@xxxxxxxxxxxx wrote:
> 
>>>>>>>This is bad. 
>>>>>>
>>>>>>This is religion. It has nothing to do with correctness or
>>>>>>robustness which is all that should be of concern here..
>>>>>
>>>>>Ok. I rephrase this to "square_iterate should be able to catch errors
>>>>>which are made by others parts of the code and not conceal the
>>>>>errors."
>>
>>There are no errors.
> 
> What happens if we have a piece of code at the server side which
> doesn't check the map position of an incoming packet. This map
> position (it may be normal, real or non-real) is than passed to
> square_iterate. We won't notice it since square_iterate without the
> assert will conceal it.
> 
> You are correct that the error is not in square_iterate. However this
> testing should be done in square_iterate.

No it most definitely should not.

But I am glad you agree that the iterators do not need this and thus
they are just being (ab)used for your religious witch hunts.

It follows that the bugs you have introduced should now be reverted to
restore the proper robustness and functionality to the code.

Please make these fixes ASAP.

>       Raimar
> 

Cheers,
RossW
=====