[Freeciv-Dev] (PR#3566) civclient crash when disconnecting from server in inconsistent state

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

I ran the server under valgrind, and connected with a client.  In the 
middle of the connection process, I changed my mind and decided to kill 
the server.

The client then crashed:

#0  0x08069765 in tile_get_known (x=24, y=3) at climap.c:36
36        return (enum known_type) map_get_tile(x, y)->known;
(gdb) bt
#0  0x08069765 in tile_get_known (x=24, y=3) at climap.c:36
#1  0x0807c676 in fill_tile_sprite_array_iso (sprs=0xbfffeef0,
     coasts=0xbfffeee0, dither=0xbfffeed0, x=24, y=3, solid_bg=0xbfffeecc)
     at tilespec.c:1728
#2  0x0809cb72 in pixmap_put_tile_iso (pm=0x838b298, x=24, y=3, 
canvas_x=512,
     canvas_y=-16, citymode=0, offset_x=0, offset_y=0, offset_y_unit=16,
     width=64, height=32, height_unit=32, draw=D_MB_LR) at mapview.c:1608
#3  0x0809b0e0 in gui_map_put_tile_iso (map_x=24, map_y=3, canvas_x=512,
     canvas_y=-16, offset_x=0, offset_y=0, offset_y_unit=16, width=64,
     height=32, height_unit=32, draw=D_MB_LR) at mapview.c:810
#4  0x08071ea9 in put_tile_iso (map_x=24, map_y=3, draw=D_MB_LR)
     at mapview_common.c:602
#5  0x08072310 in update_map_canvas (x=16, y=4, width=22, height=22,
     write_to_screen=false) at mapview_common.c:649
#6  0x080723d1 in update_map_canvas_visible () at mapview_common.c:778
#7  0x08072c51 in unqueue_mapview_updates () at mapview_common.c:1117
#8  0x08069f06 in input_from_server_till_request_got_processed (fd=16896,
     expected_request_id=4) at clinet.c:391
#9  0x080673b4 in wait_till_request_got_processed (request_id=4)
     at civclient.c:770
#10 0x080cca28 in wait_for_requests (agent_name=0x80d3b3a "CMA",
     first_request_id=3, last_request_id=4) at agents.c:641
#11 0x080cd934 in apply_result_on_server (pcity=0x846a050, 
result=0xbffff410)
     at cma_core.c:471
#12 0x080cdc13 in handle_city (pcity=0x846a050) at cma_core.c:575
#13 0x080cc05d in execute_call (call=0xbfffed74) at agents.c:166
#14 0x080cc0d0 in call_handle_methods () at agents.c:199
#15 0x08066e95 in handle_packet_input (packet=0x8480ae0, type=0)
     at civclient.c:464

This is current CVS; gtk2 client.

jason