[Freeciv-Dev] (PR#3010) core dump from client air goto

["Per I. Mathisen via RT" <rt@xxxxxxxxxxxxxx>]

To reproduce: Move an air unit with goto.

#0  0x080738cb in find_the_shortest_path (punit=0x82ca598, dest_x=49,
    dest_y=27, restriction=GOTO_MOVE_ANY) at gotohand.c:770
#1  0x08075337 in do_unit_goto (punit=0x82ca598,
restriction=GOTO_MOVE_ANY,
    trigger_special_ability=true) at gotohand.c:1312
#2  0x08059e7b in handle_unit_goto_tile (pplayer=0x8145d68, req=0x832d2e0)
    at unithand.c:95
#3  0x0804e57c in handle_packet_input (pconn=0x8115640, packet=0x832d2e0,
    type=38) at srv_main.c:868
#4  0x0809911b in sniff_packets () at sernet.c:595
#5  0x080504d5 in main_loop () at srv_main.c:1805
#6  0x08051390 in srv_loop () at srv_main.c:2140
#7  0x08050c35 in srv_main () at srv_main.c:1929
#8  0x0804a21a in main (argc=3, argv=0xbffffab4) at civserver.c:154

(gdb) list
765             die("Bad move_type in find_the_shortest_path().");
766           } /****** end switch ******/
767
768           /* Add the route to our warmap if it is worth keeping */
769           if (total_cost < maxcost) {
770             if (warmap_cost[map_inx(x1, y1)] > total_cost) {
771               warmap_cost[map_inx(x1, y1)] = total_cost;
772               add_to_mapqueue(total_cost, x1, y1);
773               local_vector[x1][y1] = 1 << DIR_REVERSE(dir);
774               freelog(LOG_DEBUG,

(gdb) p total_cost
$1 = 3
(gdb) p maxcost
$2 = 255
(gdb) p warmap_cost
$3 = (unsigned char *) 0x0

  - Per