Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2003:
[Freeciv-Dev] (PR#137) modal client dialogs
Home

[Freeciv-Dev] (PR#137) modal client dialogs

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#137) modal client dialogs
From: "Jason Short via RT" <rt@xxxxxxxxxxxxxx>
Date: Mon, 27 Jan 2003 17:43:51 -0800
Reply-to: rt@xxxxxxxxxxxxxx

[schaefer@xxxxxx - Wed Sep 22 20:10:45 1999]:

> No dialog of freeciv should be modal, i.e. lock up access
> to all other windows (like a standard windows95 yes nor or cancel box).
> The game doesn't stand still while the dialog is up either !
> 
> The gtk choose research dialog does this, however.

This patch gets rid of one occurrence where the science dialog is modal.

As discussed on IRC, popup_science_dialog should *raise* the dialog if
it's already open.  But there is no need for the whole dialog to be
modal since your research will be handled fine even if you don't choose
anything.

jason

Index: client/packhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/packhand.c,v
retrieving revision 1.277
diff -u -r1.277 packhand.c
--- client/packhand.c   2003/01/27 22:00:34     1.277
+++ client/packhand.c   2003/01/28 01:41:19
@@ -1228,7 +1228,7 @@
   if (can_client_change_view() && pplayer == game.player_ptr) {
     if(poptechup) {
       if(!game.player_ptr->ai.control || ai_popup_windows)
-       popup_science_dialog(TRUE);
+       popup_science_dialog(FALSE);
       science_dialog_update();
 
       /* If we just learned bridge building and focus is on a settler

[Prev in Thread] Current Thread [Next in Thread]