[Freeciv-Dev] Re: Don't have graphics tags

[Jason Dorje Short <vze49r5w@xxxxxxxxxxx>]

Mike Kaufman wrote:
> On Mon, Jan 20, 2003 at 12:30:00AM +0100, Rafa³ Bursig wrote:
>
> > Dnia 2003.01.20 00:21 Mike Kaufman napisa³(a):
> >
> > > On Sun, Jan 19, 2003 at 09:53:23PM +0100, Christian Knoke wrote:
> > >
> > > > 2: Loading tileset trident_shields.
> > > > 2: Don't have graphics tags b.airport or - for impr_type Flughafen
> > > > 2: Don't have graphics tags b.aqueduct or - for impr_type Aquädukt
> > > > 2: Don't have graphics tags b.bank or - for impr_type Bank
> > > > 2: Don't have graphics tags b.barracks or - for impr_type Kasernen
> > > > 2: Don't have graphics tags b.barracks or - for impr_type Kasernen
This is because I totally forgot about trident_shields.tilespec.  The 
attached patch (which I will apply) brings it up to date.
> > > this should be LOG_VERBOSE rather than LOG_NORMAL
> > static struct Sprite* lookup_sprite_tag_alt(const char *tag, const char 
> > *alt,
> > 					    bool required, const char 
> > *what,
> >                                             const char *name)
> > {
> >   struct Sprite *sp;
> >   int loglevel = required ? LOG_NORMAL : LOG_DEBUG;
> >   SDLClient require this graphic then "required" == 
> > improvement_exists(id)
>
> if it's actually _required_, then it should be LOG_ERROR or LOG_FATAL.
> write a patch for it like the isometric_view_supported() functions for each
> of the clients.
It shouldn't be required.  gui-sdl currently requires it, but it is very 
easy to check to see if the sprite exists before using it.  This should 
be done and the 'required' field should be made FALSE in the function. 
And it allows gui-sdl to work with tilesets that don't have these 
graphics (which is most of them).
I agree, though, that it makes more sense to have LOG_ERROR if the 
graphics are required and aren't present.  I wonder why it was done with 
LOG_NORMAL in the first place?  Should the client exit in this case?
jason

? data/civclient.dsc
? data/civserver.dsc
? data/civserver.room
? data/hills.spec
? data/mountains.spec
? data/theme
? data/isotrident/.xvpics
? data/isotrident/eyecandy.png
? data/isotrident/eyecandy.spec
? data/isotrident/hills.png
? data/isotrident/hills.spec
? data/nation/barsoom.ruleset
Index: data/trident_shields.tilespec
===================================================================
RCS file: /home/freeciv/CVS/freeciv/data/trident_shields.tilespec,v
retrieving revision 1.3
diff -u -r1.3 trident_shields.tilespec
--- data/trident_shields.tilespec       2000/04/02 17:26:59     1.3
+++ data/trident_shields.tilespec       2003/01/21 19:36:38
@@ -16,6 +16,11 @@
 small_tile_width   = 15
 small_tile_height  = 20
 
+is_isometric = 0
+
+; Do not blend hills and mountains together.
+is_mountainous = 0
+
 ; Font to use to draw city names:
 city_names_font = "9x15bold"
 
@@ -40,7 +45,9 @@
   "trident/units.spec",
   "trident/flags.spec",
   "trident/roads.spec",
+  "misc/buildings.spec",
   "misc/space.spec",
+  "misc/techs.spec",
   "misc/treaty.spec",
   "trident/cities.spec",
   "trident/explosions.spec",