[Freeciv-Dev] Re: (PR#2566) PATCH: clean up handle_upgrade_unittype_request

[Jason Short <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

On Wed, 2002-12-18 at 13:55, Guest via RT wrote:

> > can_upgrade_unittype is also a huge misnomer.  Do you want to 
> > provide a (separate) patch to rename it? 
>  
> I suppose I could, do you expect something like "successor_unittype"? 

Well, the name "can" implies it's a boolean return value - which is not
the case.  This confused me greatly when looking at your original patch.

I would suggest get_unittype_upgrade, but I'm no authority.  The return
type should also be changed to a unit type id.

jason