[Freeciv-Dev] Re: core file on civserver, http://civserver.freeciv.org/games/83077

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

It is an overzealous assert. 

Asserts are bad, especially when put in by people that really don't
consider all possibilities, just the one they currently want to purge.

Change the assert to "if ... return;".

Cheers,
RossW
=====

At 10:44 PM 02/12/07 +0000, Per I. Mathisen wrote:
>
>On Sat, 7 Dec 2002 freeciv@xxxxxxxxxxxxxxxxxxxxx wrote:
>> [...] teamciv-1.13.5+1.14.0b1+ourown+newdead+teamciv/share/teamciv
>
>What should be done about core dumps like this? This server is so patched
>up that it is near impossible to know where the error originated.
>
>> #30x4006f15d in __assert_fail () from /lib/libc.so.6
>> #40x0806f527 in decrement_pending_seen (pplayer=0x813d774, x=56, y=24)
>>   at maphand.c:468
>> #50x0806fcaf in fog_area (pplayer=0x813d774, x=55, y=22, len=2)
>>   at maphand.c:613
>> #60x0805b100 in move_unit (punit=0x832c908, dest_x=55, dest_y=21,
>>   transport_units=1, take_from_land=0, move_cost=6) at unittools.c:2913
>> #70x08054267 in handle_unit_move_request (punit=0x832c908, dest_x=55,
>>   dest_y=21, igzoc=0, move_diplomat_city=1) at unithand.c:1130
>> #80x0805b423 in goto_route_execute (punit=0x832c908) at unittools.c:3012
>> #90x0804cdf2 in handle_packet_input (pconn=0x80fd958, packet=0x830cea8,
>>   type=85) at srv_main.c:837
>
>Perhaps someone who has looked at this code lately can have another look
>and see if they can spot an error in cvs head.
>
>  - Per
>
>
>
>