[Freeciv-Dev] Re: (PR#2503) Starting position allocation

["aas02101@xxxxxxxxxxxxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>]

Quoting "Per I. Mathisen via RT" <rt@xxxxxxxxxxxxxx>: 
 
> On Fri, 6 Dec 2002, Gregory Berkolaiko via RT wrote: 
> > Attached is the result of my hackery on Karen's patch #2.It has been 
> > changed quite a bit, so please make sure the logic is preserved (this is 
> > especially directed to Karen). 
>  
>  
> /************************************************************************** 
>   Allocate islands array and fill in values. 
> - Note this is only use for map.generator<=1, since others 
> + Note this is only use for map.generator<=1 or >=5, since others 
>   setups islands and starters explicitly. 
>  
> **************************************************************************/ 
>  
> I wasn't aware there were mapgens other than <= 1 or >= 5... 
 
Eh? 
 
Actually in the code there is place where a check for map.generator > 0 is 
made.  I don't think there is a generator number 0... 
 
> Also, please keep to code style guide even within comments. 
 
Nitpick!! 
 
G.