Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2002:
[Freeciv-Dev] Re: (PR#1364) Assertion fails in get_role_unit()
Home

[Freeciv-Dev] Re: (PR#1364) Assertion fails in get_role_unit()

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxx, pasky@xxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#1364) Assertion fails in get_role_unit()
From: "Per I. Mathisen via RT" <rt@xxxxxxxxxxxxxx>
Date: Tue, 19 Nov 2002 07:34:37 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Tue, 19 Nov 2002, Raimar Falke via RT wrote:
> Sorry. Should read "All users in the current CVS check if the roles
> are available at all before usage." This means that:
>
> get_role_unit(role, x)
>
> is bad if you don't guard it with a
>
>  if(num_role_units(role) > 0)
>
> or it is a role which is guaranteed to exists (see the end of
> server/ruleset.c:load_ruleset_units).

Ah, ok. Did you mean to post a patch? There is none in RT, AFAICS.

  - Per




[Prev in Thread] Current Thread [Next in Thread]