Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2002:
[Freeciv-Dev] Re: (PR#1364) Assertion fails in get_role_unit()
Home

[Freeciv-Dev] Re: (PR#1364) Assertion fails in get_role_unit()

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: pasky@xxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#1364) Assertion fails in get_role_unit()
From: "Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>
Date: Tue, 19 Nov 2002 07:56:24 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Tue, Nov 19, 2002 at 07:34:37AM -0800, Per I. Mathisen via RT wrote:
> 
> On Tue, 19 Nov 2002, Raimar Falke via RT wrote:
> > Sorry. Should read "All users in the current CVS check if the roles
> > are available at all before usage." This means that:
> >
> > get_role_unit(role, x)
> >
> > is bad if you don't guard it with a
> >
> >  if(num_role_units(role) > 0)
> >
> > or it is a role which is guaranteed to exists (see the end of
> > server/ruleset.c:load_ruleset_units).
> 
> Ah, ok. Did you mean to post a patch? There is none in RT, AFAICS.

There is no problem in the CVS source -> no patch.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "How about the new language C&? No, that's not 'c ampersand', 'c reference', 
  'reference to c' or 'c and'. It's pronounced 'campersand', to confuse the 
  hell out of people who are unfamiliar with it, and it will, of course, 
  have no pointers."
    -- Xazziri in comp.lang.c++ about C#



[Prev in Thread] Current Thread [Next in Thread]