[Freeciv-Dev] Re: (PR#949) city report fields don't sort well

[Christian Knoke <chrisk@xxxxxxxx>]

On Thu, Nov 14, 2002 at 09:50:43AM -0800, Jason Short via RT wrote:
> Christian Knoke wrote:
> > On Thu, Nov 14, 2002 at 12:24:56AM -0800, Jason Short via RT wrote:
> 
> >>The problem with the patches provided so far is that they only try to
> >>treat the existing (text) fields of the city report as numerical fields,
> >>by scanning them for numerical data.  Worse still, they will only work
> >>for one GUI (gui-gtk).
> >>
> >>One alternative is to take the existing patches, and use them to provide
> >>a GUI-independent comparison function.  The functions provided by the
> >>patches do essentially the same thing: provide a comparison function to
> >>compare two strings that may or may not be integers.  This function
> >>could be used by all GUIs (at their option) to implement better sorting.
> >> A combination of the two existing patches (using Raimar's comparison
> >>code with Christian's GTK code) would be my preference.
> >>
> >>This is probably a first step.
> > 
> > 
> > That's IMO a good thing.
> 
> I agree.  Would you like to provide a patch?  IMO it should use Raimar's 
> code to compare the text fields, but the GTK elements of this function 
> should be removed and it should be put into cityrepdata.c.  Then a GTK 
> wrapper function is needed, along the lines of your patch.

I could at least try it, but certainly not within the next 3 weeks. So, if
you want to see it earlier, just do it.

Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.