[Freeciv-Dev] Re: (PR#2278) Ping version 13

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Sun, Nov 10, 2002 at 08:20:45AM -0800, Thomas Strub via RT wrote:
> On Sun, Nov 10, 2002 at 03:05:17AM -0800, Raimar Falke via RT wrote:
> > On Sat, Nov 09, 2002 at 01:11:23PM -0800, Thomas Strub via RT wrote:
> > > On Sat, Nov 09, 2002 at 04:43:17AM -0800, Raimar Falke via RT wrote:
> > > > On Sat, Nov 09, 2002 at 02:44:55AM -0800, Raimar Falke via RT wrote:
> > > > > 
> > > > > 
> > > > > This is an updated version of the ping patch from Thomas. Changes:
> > > > >  - cleanup of the packets
> > > > >  - remove the timing.[ch] changes
> > > > >  - adding the pingtime server option
> > > > >  - a lot of other cleanups
> > > > 
> > > > Version 12:
> > > >  - proper initialization of ping_time
> > > >  - check for ping_time==-1
> > > >  - send the ping_info packet only every game.ping_time seconds
> > > >  - move ping_text construction into plrdlg_common
> > > 
> > > It needs much time until the first ping information is sent to the
> > > client.
> > 
> > The client is pinged after the connection is accepted. But the sending
> > of all the ping information may take up to game.pingtime seconds.
> > 
> > > after a:
> > > 1: tried to stop already stopped timer
> > > The pings don't update.
> > > Happened after playing with 3 connections (+ 27) dropping one player and
> > > joining as the AI ...
> > > 
> > > After changing the pingtime to another value -> -2147483.-64
> > 
> > It now handles the case correct where multiple pings are outstanding.
> 
> Pingtime -2147483.-64 + cutting the player with outstanding ping (1 ping
> which wasn't answered was enough to be cut.)
> 
> After that the pings aren't updated.

Can you please run the attached changed version and post the
output. Both client and server.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Despite all the medical advances of the 20th century, the mortality 
  rate remains unchanged at 1 death per person."

ping13-1.diff
Description: Text document