[Freeciv-Dev] (PR#2271) GTK2 segfault in put_conv

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

I'm running under GTK2.  The eye candy patch is applied (but the only 
modifications it makes are in client/tilespec.[ch]).

I've been quitting and restarting the client a number of times to test 
things out.  I've noticed that each time I do so, a turn passes.  (Side 
note: is this a bug or a feature?  Sounds like a bug to me.)

Then one time I actually hit "turn done" (for the first time, I think). 
  Bam!

2: Warning: malloc with size 0 at line 178 of gui_main.c

[1]+  Segmentation fault      (core dumped) ./civ
...
#0  0x0808c7e6 in put_conv (src=0xbfffe0e0 "", length=0xbfffd07c)
     at gui_main.c:182
182         dst[len] = '\0';
(gdb) bt
#0  0x0808c7e6 in put_conv (src=0xbfffe0e0 "", length=0xbfffd07c)
     at gui_main.c:182
#1  0x080a9ab3 in dio_put_string (dout=0xbfffd0a0,
     value=0x404dd7ec "\210\036.\bÐÀA\bphB\b8öA\b\bíF\b°4C\bpíA\b\200FC\b")
     at dataio.c:325
#2  0x080b48c3 in send_packet_generic_message (pc=0x81997e0,
     type=PACKET_TURN_DONE, packet=0xbfffe0e0) at packets.c:1595
#3  0x080644de in send_turn_done () at civclient.c:508
#4  0x0806447f in user_ended_turn () at civclient.c:475
#5  0x0808e84e in end_turn_callback (w=0x82fc520, data=0x0) at 
gui_main.c:1174
#6  0x4033b796 in g_cclosure_marshal_VOID__VOID ()
    from /usr/lib/libgobject-2.0.so.0
#7  0x40326e2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#8  0x4033a993 in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
#9  0x4033920a in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#10 0x40109cdf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0
#11 0x40066eaf in gtk_button_clicked () from /usr/lib/libgtk-x11-2.0.so.0
#12 0x40067b3e in _gtk_button_paint () from /usr/lib/libgtk-x11-2.0.so.0
#13 0x4033b796 in g_cclosure_marshal_VOID__VOID ()
    from /usr/lib/libgobject-2.0.so.0
#14 0x40327205 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
#15 0x40326e2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#16 0x4033a44f in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
#17 0x4033920a in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#18 0x40109cdf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0
#19 0x40066e26 in gtk_button_released () from /usr/lib/libgtk-x11-2.0.so.0
#20 0x400679df in _gtk_button_paint () from /usr/lib/libgtk-x11-2.0.so.0
#21 0x400d4a62 in _gtk_marshal_BOOLEAN__BOXED ()
    from /usr/lib/libgtk-x11-2.0.so.0
#22 0x40327205 in g_cclosure_new_swap () from /usr/lib/libgobject-2.0.so.0
#23 0x40326e2b in g_closure_invoke () from /usr/lib/libgobject-2.0.so.0
#24 0x4033ad8a in g_signal_emit_by_name () from /usr/lib/libgobject-2.0.so.0
#25 0x40339277 in g_signal_emit_valist () from /usr/lib/libgobject-2.0.so.0
#26 0x40109cdf in gtk_signal_emit () from /usr/lib/libgtk-x11-2.0.so.0
#27 0x40189e2d in gtk_widget_send_expose () from 
/usr/lib/libgtk-x11-2.0.so.0
#28 0x40189a90 in gtk_widget_event () from /usr/lib/libgtk-x11-2.0.so.0
#29 0x400d4913 in gtk_propagate_event () from /usr/lib/libgtk-x11-2.0.so.0
#30 0x400d391e in gtk_main_do_event () from /usr/lib/libgtk-x11-2.0.so.0
#31 0x4025304c in _gdk_events_queue () from /usr/lib/libgdk-x11-2.0.so.0
#32 0x4037ba19 in g_get_current_time () from /usr/lib/libglib-2.0.so.0
#33 0x4037c837 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#34 0x4037cc13 in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#35 0x4037d2ef in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#36 0x400d302f in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#37 0x0808e4ab in ui_main (argc=1, argv=0xbffff974) at gui_main.c:1011
#38 0x08064172 in main (argc=1, argv=0xbffff974) at civclient.c:228


-jason