[Freeciv-Dev] Re: connect dialog ver 3 (PR#1911)

[Davide Pagnin <nightmare@xxxxxxxxxx>]

On Sat, 2002-10-19 at 01:58, Mike Kaufman wrote:
> for some reason jitterbug didn't forward this. if you get doubles, sorry.
> 
> On Fri, Oct 18, 2002 at 05:04:51PM -0500, Mike Kaufman wrote:
> > attached is the next version.
> > 
> > Changes:
> > 
> > o only the spawning client has access to hack level commands and really
> >   only 'save', 'load', 'rfcstyle' and 'cmdlevel'
> > o the client now communicates these hack commands through pipes. (Daniel,
> >   it seems this was the way to go all along...) The reason for this is
> >   security. Now a remote client can't take over hack.
> > o there is now a server output window (you can find it in the Game menu)
> > 
> > 
> > Notes:
> > 
> > o I feel this is for _single_player_games_. Inviting your friends to play
> >   really merits starting up a different server process don't you agree? 
> > This 
> >   is mainly the reason why I didn't include Daniels patch to show incoming 
> >   connections. It was a neat little patch, but out of sync with this 
> > project.
> > 
> > o this patch adds a couple of calls to fcntl(). I don't know if this is bad
> >   for portability. (win32 will obviously have problems) Anything else?
> > 
> > o I need reviewers! This feature is intended for please who can't/won't 
> > read 
> >   FAQS or RTFM. Is it easy enough to use? Does it do something you don't
> >   expect? Report bugs.

Here I am! As promised.

I've not started to review the code, only to use the patch.
But I have some preliminary notes.

1) Impression of the first choice menu:
With my gtk theme in the choose nation dialog, when you choose the
nation, around the flag there is a blue selection evidence, that hurts
me, but it is acceptable.
But in this first choice menu this blue selection evidence, gets a third
of the whole dialog, and is VERY annoying. 
Someone gtk skilled, can reduce the 'selection' border.

2) looking to the server output window, in the case readline is enabled,
I have seen a warning message from a rl_* function that complain about
not being attached to a terminal 

3) In my environment (CVS from 30 October), compiled on a RedHat 7.3
linux, if I load a savegame, after some seconds, I get disconnected from
the spawned civserver with this message

2: cut connection pagnin from localhost.localdomain (player Beatrix) due
to ping timeout

NOTE: I have made my tries with a notebook, not connected to the net.

ifconfig

lo        Link encap:Local Loopback  
          inet addr:127.0.0.1  Mask:255.0.0.0
          UP LOOPBACK RUNNING  MTU:16436  Metric:1
          RX packets:964 errors:0 dropped:0 overruns:0 frame:0
          TX packets:964 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:0 
          RX bytes:954957 (932.5 Kb)  TX bytes:954957 (932.5 Kb)

it is possible to reconnect to the ongoing game and continue playing

4) Known problem? If I close the civclient window, the spawned civserver
continue running.

5) player renaming inconsistency:

a) load a game (player name different from pagnin, say bini)
b) disconnect from game
c) start a new game (choose as name, pagnin)
d) disconnect from game
e) connect to game as pagnin

==> you are not allowed to join, because the user is the bini.

more to come...

> > 
> > o Vasc, the connect dialog still has a blank spot at the top where I 
> > suppose the
> >   tabs are hidden in the gtk_notebook. Could you please look at this as
> >   well as the rest of the gtk2 changes?
> > 
> > o Andreas, please let me know/get me a patch of what needs to be done 
> > regarding
> >   merging the win32 stuff into connectdlg_common.c
> > 
> > o Per, I need to add a AC_HEADER_SYS_WAIT to the configure scripts. could
> >   you do that?
> > 
> > -mike
> 

        Ciao, Davide