[Freeciv-Dev] Re: core file on civserver, http://civserver.freeciv.org/games/43550

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Oct 23, 2002 at 03:04:23PM +0200, Thomas Strub wrote:
> Hi
> 
> On Wed, Oct 09, 2002 at 01:52:39AM -0700, freeciv@xxxxxxxxxxxxxxxxxxxxx wrote:
> > #0  0x0809bd93 in send_attribute_block (pplayer=0x0, pconn=0x80fd7a8)
> >     at packets.c:4423
> > 4423          if (!pplayer->attribute_block.data)
> > (gdb) #0  0x0809bd93 in send_attribute_block (pplayer=0x0, pconn=0x80fd7a8)
> >     at packets.c:4423
> > #1  0x0804c4df in send_all_info (dest=0x80fd7d8) at srv_main.c:221
> > #2  0x0804debd in handle_request_join_game (pconn=0x80fd7a8, req=0x823fe20)
> >     at srv_main.c:1338
> > #3  0x0804ce51 in handle_packet_input (pconn=0x80fd7a8, packet=0x823fe20, 
> >     type=0) at srv_main.c:613
> 
> i have no solution for that error but i can reproduce it.
> 
> You need 2 civclients, and a game with a huge map and many units or
> cities. A plain map isn't enough. (for modemplayers smaller maps should
> be enough)
> 
> Its good that one of the players is dead so that there is a big amount
> of traffic have to sent to the client.
> 
> Then connect - disconnect with both clients as fast as you can and
> whoops the server will crash after some tries ..

It can indeed happen that the connection is closed (and so
unassociate_player_connection) after the client has joined and before
send_attribute_block is called. The attached patch should fix this.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Tank: So what do you need? Besides a miracle.
  Neo: Guns. Lots of guns.
    -- From The Matrix

send_attribute_block1.diff
Description: Text document