Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2002:
[Freeciv-Dev] Re: unused code (PR#2146)
Home

[Freeciv-Dev] Re: unused code (PR#2146)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Cc: Freeciv Development List <freeciv-dev@xxxxxxxxxxx>, Freeciv Bugs/Patch Tracking <bugs@xxxxxxxxxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: unused code (PR#2146)
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Tue, 8 Oct 2002 16:05:04 +0100 (BST)

On Tue, 8 Oct 2002, Raimar Falke wrote:

> On Tue, Oct 08, 2002 at 02:21:24PM +0100, Gregory Berkolaiko wrote:
> > Good work, Sylvain!
> > 
> > I made a patch to implement your comments.  Please check if it's alright.  
> > You are very much encouraged not only to spot bugs (which you are very
> > good at), but to submit fixes for them.  In case you do not understand
> > what I am talking about, please have a look at
> >     http://www.freeciv.org/contribute.html
> 
> We have other cases where parameter of functions aren't used. Splint
> and gcc will give you a full list of all the cases. Removing isn't the
> only option. The other changes are ok.

What do you mean by "removing isn't the only option"?

What is the general policy on that, let it stay this way?

G.




[Prev in Thread] Current Thread [Next in Thread]