Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2002:
[Freeciv-Dev] Re: Asserts and stacks in freeciv-1.13.0 GTK client (PR#20
Home

[Freeciv-Dev] Re: Asserts and stacks in freeciv-1.13.0 GTK client (PR#20

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Cc: bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Asserts and stacks in freeciv-1.13.0 GTK client (PR#2027)
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Fri, 6 Sep 2002 22:19:29 +0200

On Fri, Sep 06, 2002 at 10:25:36AM -0700, Raimar Falke wrote:
> > civclient: cityrep.c:213: append_impr_or_unit_to_menu_sub: Assertion
> > `num_selected_cities < (sizeof(selected_cities) /
> > sizeof((selected_cities)[0]))' failed.
> 
> The code assumes a maximum of 200 selected cities. Looks like we have
> to use malloc here.

And the patch.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Of course, someone who knows more about this will correct me if I'm
  wrong, and someone who knows less will correct me if I'm right."
    -- David Palmer (palmer@xxxxxxxxxxxxxxxxxx)

Attachment: selected_cities1.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]