[Freeciv-Dev] Re: Asserts and stacks in freeciv-1.13.0 GTK client (PR#2027)

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Sep 04, 2002 at 12:05:01PM +1200, <s.yeates@xxxxxxxxxxxxxxxx> wrote:
> 
> When playing with a very large civilisation I get the following asserts:
> 

>  civclient: packets.c:4427: send_attribute_block: Assertion
>  `pplayer->attribute_block.length > 0 &&
>  pplayer->attribute_block.length < (1024*64)' failed.

The length of the attribute block may exceed 64k if you use the CMA in
a lot of cities. You may want to increase MAX_ATTRIBUTE_BLOCK.

> civclient: cityrep.c:213: append_impr_or_unit_to_menu_sub: Assertion
> `num_selected_cities < (sizeof(selected_cities) /
> sizeof((selected_cities)[0]))' failed.

The code assumes a maximum of 200 selected cities. Looks like we have
to use malloc here.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Make a software that is foolproof, and only fools will want to use it.