[Freeciv-Dev] Re: end of turn activities

[rf13@xxxxxxxxxxxxxxxxxxxxxx]

On Sun, Aug 18, 2002 at 06:38:16PM +0200, Thomas Strub wrote:
> Hi,
> 
> in end_turn of server/srv_main.c there are three activities which are
> done in one go.
> 
> ( update_player_activities(pplayer); server/plrhand.c
> 
> 
> ai_do_last_activities(pplayer);  (aimovement of last turn)
> building / updating in cities
>  great_library(pplayer);
>   update_revolution(pplayer);
>   player_restore_units(pplayer); /*note: restoring move point moved
>                                  to update_unit_activities*/
>   update_city_activities(pplayer);
>   pplayer->research.changed_from=-1;
> 
> moving units checking aliveness
>  update_unit_activities(pplayer);
>   update_player_aliveness(pplayer);
> 
> I think that should be seperated in three separate functions.
> First ai-moves of the last round.

Sending new year packet.

> Second building updating units.
> Third movement of the new round.

Yes the issue is known. I stumbled on this because the new year is
send after all this activities. Which is IMHO wrong.

> Or are there any reasons to not change that?

The AI may fall apart. Nobody knows.

        Raimar