Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2002:
[Freeciv-Dev] Re: Typo fix.
Home

[Freeciv-Dev] Re: Typo fix.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gaute B Strokkenes <gs234@xxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Typo fix.
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Tue, 23 Jul 2002 13:11:00 +0200

On Sun, Jul 21, 2002 at 01:27:02AM +0200, Gaute B Strokkenes wrote:
> I just committed the following:
> 
> Index: client/gui-gtk-2.0/messagewin.c
> ===================================================================
> RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/messagewin.c,v
> retrieving revision 1.12
> diff -u -r1.12 messagewin.c
> --- client/gui-gtk-2.0/messagewin.c   2002/07/18 09:42:28     1.12
> +++ client/gui-gtk-2.0/messagewin.c   2002/07/20 23:12:45
> @@ -246,7 +246,7 @@
>    gint row = gtk_tree_selection_get_row(selection);
>  
>    if (row != -1) {
> -    struct message *message = get_message(i);
> +    struct message *message = get_message(row);
>  
>      gtk_widget_set_sensitive(meswin_goto_command, message->location_ok);
>      gtk_widget_set_sensitive(meswin_popcity_command, message->city_ok);
> @@ -262,7 +262,7 @@
>                                         gpointer data)
>  {
>    gint row = gtk_tree_path_get_indices(path)[0];
> -  struct message *message = get_message(i);
> +  struct message *message = get_message(row);
>  
>    meswin_double_click(row);
>  
> Whoever made this change never tested (or even _compiled_) the
> changes.

I can't since I don't have a GTK2 environment. So either someone has
the adopted the GTK2 client part of the patch which I posted (nobody
has done so, Vasco was away) or I just change it and apply it. And
small bugs are found. Some goes for the MUI client.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  (On the statement print "42 monkeys"+"1 snake"): BTW, both perl and Python
  get this wrong. Perl gives 43 and Python gives "42 monkeys1 snake", when 
  the answer is clearly "41 monkeys and 1 fat snake".  
    -- Jim Fulton, 10 Aug 1999


[Prev in Thread] Current Thread [Next in Thread]