[Freeciv-Dev] Re: [PATCH] User-customizable defaults for command-line arguments (PR#1800)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Baumans wrote:
> ----- Original Message -----
> From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
> To: <jdorje@xxxxxxxxxxxxxxxxxxxxx>
> Cc: <freeciv-dev@xxxxxxxxxxx>; <bugs@xxxxxxxxxxxxxxxxxxx>
> Sent: Sunday, July 21, 2002 6:21 PM
> Subject: [Freeciv-Dev] Re: [PATCH] User-customizable defaults for
> command-line arguments (PR#1800)
> > > This patch breaks the login name - you remove the user_username call but
> > > don't replace it.  As a result the login name is always "guest" unless
> > > otherwise specified.  The user_username call needs to be put back in -
> > > it could probably be left where it was before (although with a change of
> > > variables and perhaps tests), or you can move it up above the
> > > command-line check.
> > I told him to do this, and I want it to break. This is going to go away
> > anyway when client auth goes in. Besides, If you want it to be your
> > username, you can put in in the box and save it to your rc.
> >
> > Putting it back in complicates things. Is there really a good reason to
> > have it?
If this is an intentional change, then that's fine.  But, I'd think this 
is an interface issue that should get some more input from other people. 
 As a player, I'd rather have my username as the default login than 
"guest".
I see your point though, that with client authentication (however it is 
handled) this code will have to be adjusted.
> > > Although I have no sound set installed, the default remains stdsounds.
> > > It seems like after reading the soundset (and defaulting back to "none",
> > > right?), this should be updated.  But this is a minor issue.  Similarly,
> > > isotrident remains the default tileset although I cannot use isometric
> > > tilesets in XAW.
> > hmm.
> There isn't really an easy way to update this, but at least it should still
> work.  The tileset option might give a warning, although I should be able to
> change that to prevent the warning.
Upon further reflection, this is also a design issue that should get 
some input.  Personally, I'd rather have it set up so that if your 
specified tileset/soundset doesn't exist, the one that is loaded in its 
place becomes the new specification (but won't be saved unless you "Save 
Settings").
In both of the above cases (username, tileset/soundset), I don't see why 
it would be more complicated to change the value.  Just put an 
strlcpy/snprintf at the appropriate place (somewhere in civclient.c for 
the username, in the tileset/soundset loading code for the data sets). 
But, there's still the question of whether that is *desired* behavior.
> > > Another minor issue: the autoconnect option doesn't work perfectly with
> > > this system.  For instance, you can specify autoconnect=1 in your
> > > civclientrc.  Then there is no way to disable autoconnect, since the
> > > command-line option can only be used to enable it, not to disable it.
> > > This can be dealt with later, I think.
> > interesting, perhaps we shouldn't put this in the options?
> I don't think this is very useful as one of the options.  Unless you want to
> connect to the exact same server every time, which I think is rather rare,
> there's no use.  If you're going to be typing other items in on the command
> line to set up a different server, you might as well type "-a".
I don't feel strongly either way.

I don't think the above issues should stand in the way of inclusion. 
Get this into CVS, and let everyone start playing around with it so they 
can decide how they want it to work.
jason