[Freeciv-Dev] Re: [PATCH] User-customizable defaults for command-line arguments (PR#1800)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Baumans wrote:
> This patch extends options.c to allow it to store user-customisable defaults
> for most command-line arguments.  If the user doesn't specify an option on
> the command line, the default will be taken from the user's .civclientrc.
> This patch includes modifications for the GTK+, GTK+2, and XAW clients to
> allow the users to modify the defaults.
Moving forward.

This patch breaks the login name - you remove the user_username call but 
don't replace it.  As a result the login name is always "guest" unless 
otherwise specified.  The user_username call needs to be put back in - 
it could probably be left where it was before (although with a change of 
variables and perhaps tests), or you can move it up above the 
command-line check.
Although I have no sound set installed, the default remains stdsounds. 
It seems like after reading the soundset (and defaulting back to "none", 
right?), this should be updated.  But this is a minor issue.  Similarly, 
isotrident remains the default tileset although I cannot use isometric 
tilesets in XAW.
Another minor issue: the autoconnect option doesn't work perfectly with 
this system.  For instance, you can specify autoconnect=1 in your 
civclientrc.  Then there is no way to disable autoconnect, since the 
command-line option can only be used to enable it, not to disable it. 
This can be dealt with later, I think.
jason