Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2002:
[Freeciv-Dev] Re: [PATCH] User-customizable defaults for command-line ar
Home

[Freeciv-Dev] Re: [PATCH] User-customizable defaults for command-line ar

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>, <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Cc: <freeciv-dev@xxxxxxxxxxx>, <bugs@xxxxxxxxxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [PATCH] User-customizable defaults for command-line arguments (PR#1800)
From: "Baumans" <baumans@xxxxxxxxxxxxx>
Date: Sun, 21 Jul 2002 21:45:28 -0400

----- Original Message -----
From: "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>
To: <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Cc: <freeciv-dev@xxxxxxxxxxx>; <bugs@xxxxxxxxxxxxxxxxxxx>
Sent: Sunday, July 21, 2002 6:21 PM
Subject: [Freeciv-Dev] Re: [PATCH] User-customizable defaults for
command-line arguments (PR#1800)


> On Sun, Jul 21, 2002 at 12:18:17PM -0700, jdorje@xxxxxxxxxxxxxxxxxxxxx
wrote:
> > Baumans wrote:
> > > This patch extends options.c to allow it to store user-customisable
defaults
> > > for most command-line arguments.  If the user doesn't specify an
option on
> > > the command line, the default will be taken from the user's
.civclientrc.
> > > This patch includes modifications for the GTK+, GTK+2, and XAW clients
to
> > > allow the users to modify the defaults.
> >
> > Moving forward.
> >
> > This patch breaks the login name - you remove the user_username call but
> > don't replace it.  As a result the login name is always "guest" unless
> > otherwise specified.  The user_username call needs to be put back in -
> > it could probably be left where it was before (although with a change of
> > variables and perhaps tests), or you can move it up above the
> > command-line check.
>
> I told him to do this, and I want it to break. This is going to go away
> anyway when client auth goes in. Besides, If you want it to be your
> username, you can put in in the box and save it to your rc.
>
> Putting it back in complicates things. Is there really a good reason to
> have it?
>
> >
> > Although I have no sound set installed, the default remains stdsounds.
> > It seems like after reading the soundset (and defaulting back to "none",
> > right?), this should be updated.  But this is a minor issue.  Similarly,
> > isotrident remains the default tileset although I cannot use isometric
> > tilesets in XAW.
>
> hmm.
There isn't really an easy way to update this, but at least it should still
work.  The tileset option might give a warning, although I should be able to
change that to prevent the warning.
> >
> > Another minor issue: the autoconnect option doesn't work perfectly with
> > this system.  For instance, you can specify autoconnect=1 in your
> > civclientrc.  Then there is no way to disable autoconnect, since the
> > command-line option can only be used to enable it, not to disable it.
> > This can be dealt with later, I think.
>
> interesting, perhaps we shouldn't put this in the options?
I don't think this is very useful as one of the options.  Unless you want to
connect to the exact same server every time, which I think is rather rare,
there's no use.  If you're going to be typing other items in on the command
line to set up a different server, you might as well type "-a".
>
> >
> > jason
> >
>
>



[Prev in Thread] Current Thread [Next in Thread]