[Freeciv-Dev] Re: [Patch] save game load errors

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Sun, Jun 23, 2002 at 10:47:23PM -0400, Jason Short wrote:
> Raimar Falke wrote:
> > On Sun, Jun 23, 2002 at 02:31:02PM +0100, Andrew John Hughes wrote:
> > 
> >>-----BEGIN PGP SIGNED MESSAGE-----
> >>Hash: SHA1
> >>
> >>The following scenarios also fail to load into the current CVS version of 
> >>the 
> >>FreeCiv server:
> >>
> >>hagworld-120x60-v1.2.sav
> >>  -Several messages on incomplete map data
> >>earth-160x90-v2.sav
> >>  - Savegame too old, at least version 1.9.0 required.
> > 
> > 
> > As I side note I would like to propose the attached patch. It prints
> > more info and also aborts the loop after one errror.
> 
> This was originally considered unnecessary; if data is missing it gives 
> a warning but if the problem is that the map is just too old the warning 
> shouldn't be fatal.
> 
> The problem is that this same thing can happen with a corrupt map file, 
> and since the single macro works for all map data lines it is hard 
> (would be very ugly) to have the warning just for the lines that are 
> recently added (and may not be present in older save files) while having 
> a fatal error if other lines are missing.
> 
> I don't feel strongly either way.  On the one hand, anyone using an old 
> map should upgrade it.  On the other, there's no real reason to stop if 
> a map data line isn't present; some users may want to continue and the 
> others will at least get the warning (which should let them know to stop).

New version attached. Warning is printed only one time but the map is
loaded fully.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "brand memory are for windows users that think their stability
   problems come from the memory"
    -- bomek in #freeciv

load_game_error2.diff
Description: Text document