[Freeciv-Dev] Re: [PATCH] /fix and /free commands; allow /score after game has ended (PR#1582)

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Sun, Jun 16, 2002 at 03:24:43PM -0700, Reinier Post wrote:
> These commands are experimental. /fix can be given before the game starts
> to make an option non-modifiable during runtime.  This can be used on
> public servers to prevent the /set allowconnect DOS problem (PR#1139)
> and related issues, which have been causing unrest on civserver.freeciv.org.
> 
> /free is just to undo /fix.
> 
> Attached is the current CVS version (Jun 16).  A 1.12.0 version is at
> 
>   http://civserver.freeciv.org/patches/1.12.0/fixfree.patch
> 
> Please report problems, I have done no more than rudimentary testing.
> Known issue: the 'fixedness' of options is not recorded to savegames.
> (It is recorded with /write.)

Obvious this is post release stuff.

> I couldn't resist to include a second feature, which, if I entered it
> on its own, would be the shortest patch possible: 1 character!
> It allows the /score command to be used after the game has ended.

>    case CMD_SCORE:
> -    if(server_state==RUN_GAME_STATE) {
> +    if (server_state>=RUN_GAME_STATE) {
>        report_scores(FALSE);
>      } else {
>        cmd_reply(cmd, caller, C_SYNTAX,

This one is a bug fix. Although I would prefer a more explicit
state==foo || state==bar.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Microsoft does have a year 2000 problem. I'm part of it. I'm running Linux.