[Freeciv-Dev] Re: [RFC] Move cost map interface

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Apr 26, 2002 at 04:31:53PM +0100, Gregory Berkolaiko wrote:
> On Thu, 25 Apr 2002, Raimar Falke wrote:
> 
> > On Thu, Apr 25, 2002 at 06:10:51PM +0100, Gregory Berkolaiko wrote:
> > > On Wed, 24 Apr 2002, Raimar Falke wrote:
> > > 
> > > >  - added move_expended array
> > > 
> > > The information given by 
> > >   moves_expended, initial_moves
> > > and by 
> > >   turn, move_left
> > > is equivalent.  So I think it is excessive to have both of them.
> > > If I were you, I would convert moves_left to an array though (however it 
> > > only makes sense for MINIMAL and MAXIMAL modes).
> > > Again, this is not an area of my immediate interest.
> 
> Any comments on the above?

I'm still working on it.

> > > 5. I can foresee a lot of confusion with position / location names.  Thus 
> > > I reccommend to change pf_position to pf_node (as in node of the route).
> > 
> > We can define the terms position and location at the top. Problem
> > solved IMHO.
> 
> Of course we should define and comment everything.  I take it for granted.  
> Still position and location are very similar words (Merriam-Webster: 
> synonyms of position: place, location, locus etc).  Being of poor mind 
> power I won't be able to remember which is which.  And I don't want to go 
> and consult the comments whenever I need to refer to one.
> 
> So if you don't mind, I'd really prefer to rename pf_postion to pf_node.

I would rather rename pf_location. But I don't see a big problem since
pf_position is only used in last_position_on_path.

> > > 6. I hope that you do not consider this interface as wrought in stone.
> > 
> > I have no problem changing the interface in small areas.
> 
> cool.

I will use this freedom soon ;)

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Last year, out in California, at a PC users group, there was a demo of
  smart speech recognition software. Before the demonstrator could begin
  his demo, a voice called out from the audience: "Format c, return. Yes,
  return." Damned short demo, it was.