Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2002:
[Freeciv-Dev] Re: [Patch] Sound #16
Home

[Freeciv-Dev] Re: [Patch] Sound #16

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [Patch] Sound #16
From: Per I Mathisen <per@xxxxxxxxxxx>
Date: Tue, 16 Apr 2002 17:58:59 +0200 (MEST)

On Mon, 15 Apr 2002, Raimar Falke wrote:
> > Changes to version 15:
>    - requests from Per

What requests?

> The stdsounds sound set is available from incomming. These should from
> now on be numbered.

Numbered?

> The civ2spec should also be left out of the CVS tree.

Agreed. Also leave out stdsounds.spec, since it should follow the sound
tarball.

Now, you did include civ2sounds.spec in the patch, but you didn't include
stdsounds.spec, but both are referred to in Makefile.am! So this patch is
needed in order to compile:

--- freeciv/data/Makefile.am    Tue Apr 16 18:01:54 2002
+++ freeciv-dunno/data/Makefile.am      Tue Apr 16 17:59:27 2002
@@ -11,9 +11,7 @@
        hires.tilespec \
        helpdata.txt    \
        civ1.serv       \
-       civ2.serv       \
-       civ2sounds.spec \
-       stdsounds.spec
+       civ2.serv

 EXTRA_DIST = $(pkgdata_DATA)

> Please test.

With patch above: Looks fine, works fine.

Quacks like a good patch, walks like a good patch... now we just need it
committed to cvs :-)

Yours,
Per

"Treason doth never prosper: what's the reason?
Why, if it prosper, none dare call it treason."
 -- Sir John Harrington (1561-1612)




[Prev in Thread] Current Thread [Next in Thread]