[Freeciv-Dev] Re: [Patch] Sound #16

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Apr 16, 2002 at 05:58:59PM +0200, Per I Mathisen wrote:
> On Mon, 15 Apr 2002, Raimar Falke wrote:
> > > Changes to version 15:
> >    - requests from Per
> 
> What requests?

Your comments on #15.

> > The stdsounds sound set is available from incomming. These should from
> > now on be numbered.
> 
> Numbered?

stdsounds1.tar.gz, stdsounds2.tar.gz, stdsounds3.tar.gz,... You get the idea ;)

> > The civ2spec should also be left out of the CVS tree.
> 
> Agreed. Also leave out stdsounds.spec, since it should follow the sound
> tarball.
>
> Now, you did include civ2sounds.spec in the patch

Bug.

> , but you didn't include
> stdsounds.spec, but both are referred to in Makefile.am!

Another bug.

> So this patch is needed in order to compile:
> 
> --- freeciv/data/Makefile.am    Tue Apr 16 18:01:54 2002
> +++ freeciv-dunno/data/Makefile.am      Tue Apr 16 17:59:27 2002
> @@ -11,9 +11,7 @@
>         hires.tilespec \
>         helpdata.txt    \
>         civ1.serv       \
> -       civ2.serv       \
> -       civ2sounds.spec \
> -       stdsounds.spec
> +       civ2.serv
> 
>  EXTRA_DIST = $(pkgdata_DATA)
> 
> > Please test.
> 
> With patch above: Looks fine, works fine.
> 
> Quacks like a good patch, walks like a good patch... now we just need it
> committed to cvs :-)

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "This is Linux Country. On a quiet night, you can hear Windows reboot."