Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2002:
[Freeciv-Dev] Re: Make use of do_unit_goto return value. (PR#1253)
Home

[Freeciv-Dev] Re: Make use of do_unit_goto return value. (PR#1253)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Make use of do_unit_goto return value. (PR#1253)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 4 Apr 2002 17:43:26 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Fri, Feb 08, 2002 at 08:16:35AM -0800, Gregory Berkolaiko wrote:
> The attached patch makes use of the return value of the functions
> do_unit_goto (several occurences) and goto_route_execute (one occurence).
> So as to not introduce any sturctural changes, not all occurences of
> do_unit_goto were changed.
> 
> The immediate result of this is that Raimar's Spliff package won't
> complain as much.  Also the code is slightly more readable. 
> More extensive use of the return values will hopefully come with the
> cleanup of the caller functions.
> 
> Weird formatting in .diff file is caused by tabulation that emacs insists
> on using.  If anyone can explain me how to make emacs pad with
> whitespace, I will be grateful.
> 
> Patch is done against todays CVS (08/08/2002).
> The savegames are identical.
> Affected files:
>  ai/aiunit.c
>  server/unittools.c

Updated version attached.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The Software is not designed or licensed for use in on-line control
  equipment in hazardous environments, such as operation of nuclear
  facilities, aircraft navigation or control, or direct life support
  machines. 
    -- Java Compiler Compiler Download and License Agreement

Attachment: use_do_unit_goto2.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]