Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2002:
[Freeciv-Dev] Re: Make use of do_unit_goto return value. (PR#1253)
Home

[Freeciv-Dev] Re: Make use of do_unit_goto return value. (PR#1253)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx, <bugs@xxxxxxxxxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Make use of do_unit_goto return value. (PR#1253)
From: Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 5 Apr 2002 13:25:18 +0100 (BST)

On Thu, 4 Apr 2002, Raimar Falke wrote:

> On Fri, Feb 08, 2002 at 08:16:35AM -0800, Gregory Berkolaiko wrote:
> > The attached patch makes use of the return value of the functions
> > do_unit_goto (several occurences) and goto_route_execute (one occurence).
> > So as to not introduce any sturctural changes, not all occurences of
> > do_unit_goto were changed.
> > 
> > The immediate result of this is that Raimar's Spliff package won't
> > complain as much.  Also the code is slightly more readable. 
> > More extensive use of the return values will hopefully come with the
> > cleanup of the caller functions.
> > 
> > Weird formatting in .diff file is caused by tabulation that emacs insists
> > on using.  If anyone can explain me how to make emacs pad with
> > whitespace, I will be grateful.
> > 
> > Patch is done against todays CVS (08/08/2002).
> > The savegames are identical.
> > Affected files:
> >  ai/aiunit.c
> >  server/unittools.c
> 
> Updated version attached.
> 
>       Raimar

I think it should be applied before it becomes outdated again.
I suspect updating it wasn't that easy (looking at the change in the line 
numbers).

G.




[Prev in Thread] Current Thread [Next in Thread]