Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2002:
[Freeciv-Dev] Re: [PATCH] try to cleanup assess_danger part2 (PR#1322) 		Home

[Freeciv-Dev] Re: [PATCH] try to cleanup assess_danger part2 (PR#1322)

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Markus Linnala <maage@xxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] try to cleanup assess_danger part2 (PR#1322)
From: Raahul Kumar <raahul_da_man@xxxxxxxxx>
Date: Tue, 12 Mar 2002 02:56:52 -0800 (PST) 
--- Markus Linnala <maage@xxxxxxxxx> wrote:
> 
> Part 2 of assess_danger cleanup. This is on top of '[PATCH} try to cleanup
> assess_danger (PR#1321)'.
> 

I hate to be negative, but I don't like this patch. The make virtual unit 
function is ok. Assess danger unit is positively useless. It just repeats what
is already done far too many times in the combat calcs that Raimar just fixed
up.

Don't give up Markus. I think this could be turned into a good patch with a
little bit of effort.



__________________________________________________
Do You Yahoo!?
Try FREE Yahoo! Mail - the world's greatest free email!
http://mail.yahoo.com/
[Prev in Thread] Current Thread [Next in Thread]