[Freeciv-Dev] Re: Economy report (PR#1307)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Mar 08, 2002 at 03:43:41PM +0000, Ben Webb wrote:
> On Fri, 8 Mar 2002, Raimar Falke wrote:
> 
> > I don't have access to a 64bit system here.
> 
> What's wrong with the SourceForge compile farm?

Thanks for the hint. I get some of these:
  warning: cast increases required alignment of target type
If I understand this correct you shouldn't do
 char *p;
 int *q;
 void *r;

 q=(int *)p;

Since q may have stronger alignment requirements than p. Note that
 q=r;
is ok. So we have to change the type of a generic pointer from char *
to void *. Correct?!

> > So you may can provide patch or error messages.
> 
> I did, but you only applied part of it. ;)
> See http://arch.freeciv.org/freeciv-dev-200110/msg00302.html
> 
>       Since then, lots of other gint/gpointer problems have crept in; 
> see attached patch.
> 
> As for the size_t problem, this was partly addressed by 
> http://arch.freeciv.org/freeciv-dev-200202/msg00137.html. (If the "%zt" 
> format specifier isn't good enough for printing size_t's, e.g. from 
> sizeof, then I guess casting to unsigned long is a reasonable compromise.)

I'm for the unsigned long cast.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 Make a software that is foolproof, and only fools will want to use it.