[Freeciv-Dev] Re: Economy report (PR#1307)

[Jason Short <vze2zq63@xxxxxxxxxxx>]

Ben Webb wrote:
> On Fri, 8 Mar 2002, Raimar Falke wrote:
>
>
> > -Wshadow -Werror NOW!! ;)
> 	That'd be nice, except that then Freeciv would fail to build on 
> an Alpha...
Raimar means it for local compilation, i.e.

  make CFLAGS="-Wshadow -Werror"

with whatever other flags you want also included.  Of course, I would 
have imagined there were a lot of other shadowed variables causing 
things not to compile at all like this, but maybe Raimar's fixed these now.
But, this would not have helped in this case.  Whoever compiled the code 
with these flags would have seen the shadow, fixed it (which I did in 
passing), and probably not noticed the *real* error.
jason