[Freeciv-Dev] Re: [Patch]Defence Power

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

It looks good. It should go into CVS immediately. I have a few questions

How is this used?

d = m; 

If use_alternative_hp is TRUE the given alternative_hp value is used. 

Is this to deal with injured units, and we use max hps to see how tough the
unit would be if it recovered? It seemed obvious to me that the AI should use
the unit's current hps. Obviously you see a need in the future for
alternative_hps.

I see a few lines like this

power = (power * db) / 10;

I was wondering if the 10 is a new number or good old POWER_FACTOR, it shows up
fairly often.

And, why does the patch seem so small? In spite of the size increase, it seems
simpler. It is, finally, pretty code.



__________________________________________________
Do You Yahoo!?
Try FREE Yahoo! Mail - the world's greatest free email!
http://mail.yahoo.com/