[Freeciv-Dev] Re: unit_type_iterate (PR#1302)
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
--- jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
> Now that the impr_type_iterate change is in, here's an updated
> unit_type_iterate.
>
> In most cases I've avoided renaming the variable of iteration, even
> though they are often badly named and may shadow function-wide definitions.
>
> In only one case should the compiled code be changed: send_ruleset_units
> in server/ruleset.c. This was the sole loop that iterated over the
> unit_types pointer rather than with an integer.
>
It looks good. Here's hoping it becomes part of CVS quickly.
__________________________________________________
Do You Yahoo!?
Try FREE Yahoo! Mail - the world's greatest free email!
http://mail.yahoo.com/
|
|
