[Freeciv-Dev] Re: [Patch]Defence Power

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Mar 06, 2002 at 12:22:19AM -0800, Raahul Kumar wrote:
> > It looks good. It should go into CVS immediately. I have a few questions
> > 
> > How is this used?
> > 
> > d = m; 
> 
> Removed.

Good.


> No. We either do to calculate the vulnerability
>  - for a unit type (use_alternative_hp==FALSE) for example if we plan
>  the build one or

It would be nice to see this as a comment.
 
>  - for an existing unit (use_alternative_hp==TRUE, provide
>  the actual hps as another argument).
> 

<snip>

> POWER_FACTOR is only used with attack_strength and
> defense_strength. From data/default/terrain.ruleset:
> 
> ; defense_bonus        = 10 times actual; typically 10 to 30 (1.0 to 3.0)
> 
> This is another 10. But an external visible one. May this should be
> converted to percents.
> 

I would prefer that. Even as is though, this patch can be applied. These are
minor nitpicks.

> > And, why does the patch seem so small? In spite of the size
> > increase, it seems simpler. It is, finally, pretty code.
> 
>       Raimar
> 


__________________________________________________
Do You Yahoo!?
Try FREE Yahoo! Mail - the world's greatest free email!
http://mail.yahoo.com/