[Freeciv-Dev] In city report, change list falls off bottom of screen sometimes, so some units cannot be selected (PR#1285)

[jonadab@xxxxxxxxxx]

Full_Name: Nathan Eady
Version: 1.12.0
Distribution: Built from source
Client: Gtk+
OS: Linux Mandrake 8.1
Submission from: (NULL) (209.143.57.90)



[Yet another maximum-size-map fan finds city report bugs...]

Steps to reproduce:

1.  Use a small-to-medium resolution (not more than about 1024x768).
2.  Do enough research that you can build a fair assortment of things.
3.  Open the cities report.
4.  Select several cities that have many options for what to produce.
5.  Press the Change button (not Change All, just Change; Change All
    is not always appropriate, for example, if you want all the cities 
    on a certain island to switch to Battleships or somesuch).

Results:

If the list of available options exceeds your total y res (768 
pixels in my case), the later options will be unavailable.  If you
want to change a couple hundred cities at once and get them making 
that new unit type that just became available, without stopping
all production of some other unit type, this leaves you with the
unattractive option of popping open a couple hundred city dialogs,
or the somewhat clever workaround of changing them to build one
of the available obsolete wonders (or anything else none of your
cities are really building) and then using Change All from there.  

Presence of that workaround makes this a bug I can live with, but 
it loses production points when one could otherwise change directly 
from one unit to another.  (If there's a unit high on the list
that you don't want any city building, then loss of production
points doesn't apply; Alpine Troops are often good for this, once
mobile war is discovered so that you don't actually need them.)

Possible fixes include a scrollbar, a second column, or, my 
personal favourite, popping up a dialog box like Change All 
does (only without the From: part, obviously).  

Problem exists in Gtk client and also in Windows native port;
have not tested with Athena widgets.