[Freeciv-Dev] Re: [PATCH] [1.2] move some common AI equations to kill_desire() (PR#1279)

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Mon, Feb 25, 2002 at 01:41:39PM CET, I got a letter,
where Raahul Kumar <raahul_da_man@xxxxxxxxx> told me, that...
> > --- advmilitary.c   22 Feb 2002 19:32:40 -0000      1.1.1.9
> > +++ advmilitary.c   24 Feb 2002 21:36:20 -0000      1.2
> > @@ -620,7 +620,7 @@
> >                unit_types[i].move_type == HELI_MOVING) && acity &&
> >                acity->ai.invasion == 2) b0 = f * SHIELD_WEIGHTING;
> >        else {
> > -        b0 = (b * a - (f + (acity ? acity->ai.f : 0)) * d) * g *
> > SHIELD_WEIGHTING / (a + g * d);
> > +        b0 = kill_desire(b, a, (f + (acity ? acity->ai.f : 0)), d, g);
> >          if (acity && b * acity->ai.a * acity->ai.a > acity->ai.f * d)
> >            b0 -= (b * acity->ai.a * acity->ai.a - acity->ai.f * d) *
> >                             g * SHIELD_WEIGHTING / (acity->ai.a * 
> > acity->ai.a
> > + g * d);
> 
> Kill those a,b,c,d. I think you have better names for those.

I do (basically it looks that same substitution as in findvictim applies) -
however, as I said, it won't be in this patch.

> > --- aiunit.c        23 Feb 2002 21:03:31 -0000      1.1.1.10
> > +++ aiunit.c        24 Feb 2002 21:36:20 -0000      1.45
> > @@ -616,6 +616,30 @@
> >  }
> >  
> >  /**************************************************************************
> > +Compute how much we want to kill certain victim we've chosen.
> > +
> > +Benefit is something like 'attractiveness' of the victim, how nice it would
> > be
> > +to destroy it. Larger value, worse loss for enemy.
> > +
> > +Attack is the total possible attack power we can throw on the victim. Note
> > that
> > +we will even square this.
> > +
> > +Loss is the possible loss when we would lose the unit we want to attack.
> > +
> > +Vuln is vulnerability of our unit when attacking the enemy.
> > +**************************************************************************/
> 
> Victim count is the only one missing. Victim count does not count stacked 
> units
> right as far as I know.

Please elaborate.

I'll add description of victim count, thanks.

Improved patch attached (only this changes).

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/

killdesire.patch
Description: Text document